Repository navigation
ci: Pin pre-commit hooks to commit SHAs - #180
Merged
Merged
Conversation
armenzg
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: CI / workflow hardening (supply chain). No outstanding application security, runtime dependency, or build/deploy issue was found, so this is the top remaining item.
Severity: low.
Issue:
.pre-commit-config.yamlreferenced all six hook repos by mutable tags (23.12.1,v4.2.0, …). pre-commit fetches and runs that code on contributors' machines and in CI, so anyone who can move one of those tags upstream (compromised maintainer account, force-pushed tag) could run arbitrary code there.Fix: pin each hook
revto the commit SHA its current tag points to, with a# frozen: <tag>comment sopre-commit autoupdate --freezekeeps working. The hook versions do not change. Pinned hooks:ec91a2be07319853db7346d346907333f22ea06506a39750Each SHA matches what
git ls-remotereturns for that tag (peeled for annotated tags).via @armenzg.
--
View Session [Sentry]